Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port debug overlays to IRenderAboveShroud #17042

Merged
merged 8 commits into from Sep 14, 2019

Conversation

@pchote
Copy link
Member

pchote commented Sep 3, 2019

This PR implements another (and the messiest) prereq for #10382. Most of the debug overlays were previously using the old IRenderAboveWorld interface, which meant they would be drawn at the world resolution (which looks really bad) when we switch to the split rendering model.

This ports them over to IRenderAboveShroud and adds new IRenderable types to clean up their rendering. The *AnnotationRenderable naming scheme is chosen to match the next PR, which will split an IRenderAnnotation interface from IRenderAboveShroud - IRenderAboveShroud will be drawn as part of the world (zoom and GPU-based scroll), while IRenderAnnotation is drawn as part of the UI (different zoom, CPU-based scroll).

The main visible change is that the TerrainGeometryOverlay is no longer hidden by the shroud borders. Moving to solid circles and dropping target markers cause some minor visual tweaks for the sake of simplicity.

This also fixes the always-visible rendering mode for WithRangeCircle to match the on-selection mode wrt shroud and annotations.

@pchote pchote force-pushed the pchote:debug-overlay-renderables branch from 867b9e2 to af605a4 Sep 4, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Sep 4, 2019

Rebased.

@pchote pchote requested review from reaperrr, abcdefg30 and teinarss Sep 9, 2019
@pchote pchote force-pushed the pchote:debug-overlay-renderables branch from af605a4 to 54681d6 Sep 12, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Sep 12, 2019

Rebased.

Copy link
Member

abcdefg30 left a comment

The terrain grid of the map editor doesn't render at all when the zoom level is 2 and it looks really awful on 0.25 now:
grafik

@pchote pchote force-pushed the pchote:debug-overlay-renderables branch from 54681d6 to 5649d89 Sep 13, 2019
@pchote pchote requested a review from abcdefg30 Sep 13, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Sep 13, 2019

Fixed.

Copy link
Member

abcdefg30 left a comment

Didn't spot any regressions during a quick test.

@pchote pchote force-pushed the pchote:debug-overlay-renderables branch from 5649d89 to ee4616a Sep 14, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Sep 14, 2019

Rebased.

@teinarss teinarss merged commit 0e6c37d into OpenRA:bleed Sep 14, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote pchote deleted the pchote:debug-overlay-renderables branch Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.