Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in allies03a #17065

Merged
merged 2 commits into from Sep 15, 2019

Conversation

@abcdefg30
Copy link
Member

commented Sep 7, 2019

Fixes #17062 which is a regression from #15680.

Testcase: Destroy the entire base except the construction yard. Then capture it. That triggers the camera removal. Then sell or undeploy it (triggering it a second time).

@abcdefg30 abcdefg30 added this to the Next Release milestone Sep 7, 2019
@pchote

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

[22:07:57] | hm, I might have successfully broken half of our RA missions with #15680
[22:07:58] | Pull request #15680 (closed) by abcdefg30: Fix OnAllRemovedFromWorld only triggering once | http://bugs.openra.net/15680
[22:08:11] | now it makes sense why infiltration was weirding out

Do we need to worry about other missions here too?

Copy link
Member

left a comment

In any case, confirmed the allies03a fix.

abcdefg30 added 2 commits Sep 7, 2019
It is weird, unsatisfying for the player and inconsistent with the rest of our missions
@abcdefg30 abcdefg30 force-pushed the abcdefg30:baseCam branch from e3c661f to 99134f4 Sep 9, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

Updated to include other missions as well.

Copy link
Contributor

left a comment

LGTM and no other OnAllRemovedFromWorld involves a conyard as far as I can see.

@reaperrr reaperrr merged commit 0462cfa into OpenRA:bleed Sep 15, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:baseCam branch Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.