Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate hotkey tracking in the hotkey definition #17079

Merged
merged 1 commit into from Sep 15, 2019

Conversation

@dragunoff
Copy link
Contributor

commented Sep 11, 2019

This is a follow up to #16816 (see #16816 (comment)). I opted for a boolean because it's easier to manage and I think it covers the base here.

@abcdefg30 abcdefg30 merged commit 32309bb into OpenRA:bleed Sep 15, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -20,6 +20,7 @@ public sealed class HotkeyDefinition
public readonly Hotkey Default = Hotkey.Invalid;
public readonly string Description = "";
public readonly HashSet<string> Types = new HashSet<string>();
public bool HasDuplicates = false;

This comment has been minimized.

Copy link
@pchote

pchote Sep 15, 2019

Member

This really needs to be set as part of the HotkeyManager parsing! In principle any part of the game code could query this, and will read a wrong / uninitialized value.

This comment has been minimized.

Copy link
@dragunoff

dragunoff Sep 16, 2019

Author Contributor

I see. I will file a follow up.

@dragunoff dragunoff deleted the dragunoff:feature/duplicate-hotkeys branch Sep 20, 2019
@pchote

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Cherry picked to prep (9d98276) and added to #16816's changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.