Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdi08a #17085

Merged
merged 1 commit into from Mar 17, 2020
Merged

Add gdi08a #17085

merged 1 commit into from Mar 17, 2020

Conversation

@fruestueck
Copy link
Contributor

fruestueck commented Sep 12, 2019

Adds mission 8a "Restore GDI Presence Near Salzburg" for the Tiberian Dawn GDI campaign (#4988).

The Lua script is similar to gdi09 #16834 .

Have fun testing! : )

Changes & Notes:

  • The Missiontitle seems to be to long for the missionbrowser.
  • A HQ (Comm center) and Nuke (Powerplant) has been added offmap to allow Nod building ltnk, arty and e4. They are removed via OnKilledOrCaptured(nodconyard).
    Prerequesits reduced to anycyard and ~techleve.low
  • For the Atk1, Atk2, Nod1 to 6 and Auto1 to 7 AttackWaves the lua-script (from mission scb09ea) is just grabbing available (IsIdle) Untis. As the Airfield and HandofNod produces these units by random, some attack waves may be incomplete at different playthrough.
  • This could be changed to spawn the required units at GameStart. Alternatively the required Units could be built with a buildqueue.
  • Idling units in the woods are patrolling their starting location. This prevents them from being picked for an AttackWave
  • The civilian seems to have a patrol into the town and back. As he would be shot instantly by the nod e1 the patrol was not implemented. He also got a name as an easteregg.

Import log:

-Details----------------------------------------------------
Name   : GDI Mission 8a, Salzburg
Mission: scg08ea.ini
Source : CNC Gold
Tool   : OpenRA.Utility.exe, bleed 09.09.2019
Reference: https://cnc.fandom.com/wiki/Restore_GDI_Presence_Near_Salzburg
-Result-----------------------------------------------------
Ignoring unknown MaxBuilding=150 for player BadGuy
Ignoring unknown MaxUnit=238 for player BadGuy
Ignoring unknown Credits=30 for player BadGuy
Ignoring unknown Edge=West for player BadGuy
Ignoring unknown MaxBuilding=150 for player Neutral
Ignoring unknown MaxUnit=150 for player Neutral
Ignoring unknown Edge=North for player Neutral
Ignoring unknown Credits=0 for player Neutral
Ignoring unknown MaxBuilding=150 for player GoodGuy
Ignoring unknown MaxUnit=160 for player GoodGuy
Ignoring unknown Credits=50 for player GoodGuy
Ignoring unknown Edge=South for player GoodGuy
scg08ea.oramap saved.

Possible TiberiumTreeCreation adjustment after #16827 is merged.


Updated: Added Secondary Goal "Repair GDI base and vehicles"

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 4, 2019

Putting this on wait for #16834. Once we fixed some of the issues there, things will get clearer here as well.

@fruestueck fruestueck force-pushed the fruestueck:scg08ea branch 2 times, most recently from 94ae471 to 5ea9f60 Oct 14, 2019
@fruestueck fruestueck force-pushed the fruestueck:scg08ea branch 3 times, most recently from c172a65 to 331a68a Dec 31, 2019
@fruestueck

This comment has been minimized.

Copy link
Contributor Author

fruestueck commented Dec 31, 2019

Adapted to global mission script.

@fruestueck fruestueck force-pushed the fruestueck:scg08ea branch from 331a68a to 787feac Dec 31, 2019
mods/cnc/maps/gdi08a/gdi08a-AI.lua Outdated Show resolved Hide resolved
mods/cnc/maps/gdi08a/gdi08a.lua Outdated Show resolved Hide resolved
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 12, 2020

Fwiw, this also doesn't add the Lua scripts to the sln yet.

@obrakmann obrakmann mentioned this pull request Jan 13, 2020
7 of 8 tasks complete
@fruestueck fruestueck force-pushed the fruestueck:scg08ea branch from 787feac to 3eb4942 Jan 13, 2020
Copy link
Member

Mailaender left a comment

Looking good.

@Mailaender

This comment has been minimized.

Copy link
Member

Mailaender commented Feb 29, 2020

I only noticed that the guarding units are pretty vulnerable to artillery fire as they keep stationary even when attacked.

@fruestueck

This comment has been minimized.

Copy link
Contributor Author

fruestueck commented Mar 7, 2020

I only noticed that the guarding units are pretty vulnerable ...

That seems true.
I haven't seen a more suitable solution to keep the units from beeing grabbed for the attack waves without reprogramming the attack wave logic. Same behaviour as with #17514

@abcdefg30 abcdefg30 force-pushed the fruestueck:scg08ea branch from 3eb4942 to 0cff91f Mar 17, 2020
@abcdefg30 abcdefg30 force-pushed the fruestueck:scg08ea branch from 0cff91f to 4747031 Mar 17, 2020
Copy link
Member

abcdefg30 left a comment

Rebased and did a few fixups.

@abcdefg30 abcdefg30 merged commit dffa1e4 into OpenRA:bleed Mar 17, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Mar 17, 2020

@pchote pchote added this to the Next Release milestone Mar 19, 2020
@fruestueck fruestueck deleted the fruestueck:scg08ea branch Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.