Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the expansion mcv in soviet05 being transported off the map #17122

Merged
merged 1 commit into from Sep 28, 2019

Conversation

@abcdefg30
Copy link
Member

commented Sep 18, 2019

Loading a unit into a transport seems to cancel all queued activities of the transport, so we have to let the mcv enter before queueing the first transport movements in the delayed function. Otherwise the move queued to the island gets cancelled and then the transport moves off the map because of the orders in the later Trigger.AfterDelay functions.

Testcase is simple: Either start the mission on hard to trigger the movement, or start on a different difficulty and build a sub pen using the dev cheats. You'll notice the transport with the mcv leaving the map on bleed.

@abcdefg30 abcdefg30 added this to the Next Release milestone Sep 18, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2019

While testing for #17124 I noticed that the mcv sometimes doesn't get loaded into the transport in the first place. This is fixed in this PR as well.

@reaperrr reaperrr merged commit 4113167 into OpenRA:bleed Sep 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:sovs05 branch Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.