Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the search radius decrease in TS and D2k #17139

Merged
merged 2 commits into from Sep 28, 2019

Conversation

@abcdefg30
Copy link
Member

commented Sep 22, 2019

Looks like I was a bit too enthusiastic in #16920. Fixes #17115.

@tovl

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2019

We might want to do the same for D2K. The rock/sand divide makes mining distances naturally longer in that game (which is why carryalls exist).

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2019

You are probably right. Done. I counted the count of tiles from the most secluded corner to the nearest patch on some maps and it is usually not more than 40, so the values should work unless you place your refinery away from the spice on purpose.

@abcdefg30 abcdefg30 changed the title Revert the search radius decrease in TS Revert the search radius decrease in TS and D2k Sep 22, 2019
@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Since this now affects D2k as well, at least the 2nd commit should be picked to prep.

@reaperrr reaperrr added this to the Next Release milestone Sep 26, 2019
@tovl
tovl approved these changes Sep 27, 2019
Copy link
Contributor

left a comment

👍

Copy link
Contributor

left a comment

Fixes ts shellmap. Three random missions in D2K worked as intended

@reaperrr reaperrr merged commit 4d2b70a into OpenRA:bleed Sep 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:revertTs branch Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.