Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actors returning fire at invisible attackers #17150

Merged
merged 2 commits into from Nov 8, 2019
Merged

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Sep 26, 2019

Closes #16335.
Closes #16461.

Reproduction case:

  • Place two teslas inside arms range, but outside vision range
  • Move a single rifle man right next to one coil into the vision range of the other coil
  • The other coil will kill the rifle man and although not doing damage still hit the first coil
  • The first coil will start firing at the unrevealed tesla coil

Illustration:
grafik

@abcdefg30 abcdefg30 force-pushed the abcdefg30:backfired branch from 9b68774 to 248295b Sep 26, 2019
However, this does not check if any existing IMove traits are enabled.
@Punsho

This comment has been minimized.

Copy link
Contributor

Punsho commented Sep 26, 2019

related #16335

@reaperrr reaperrr mentioned this pull request Nov 3, 2019
12 of 19 tasks complete
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Nov 8, 2019

Code looks good to me, but not tested yet.
If someone else (maybe @matjaeck ?) can confirm that it works as intended before I get around to testing it myself, lgtm.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Nov 8, 2019

@reaperrr Sure, I'll post my findings later today.

Copy link
Contributor

matjaeck left a comment

The bug that tesla coils return fire at unrevealed actors is fixed. Their range has already been lowered to equal their vision in #17077 fwiw, so you'll need to revert that for testing the original issue. I didn't notice any changes wrt unit behavior for humans and AI, so LGTM.

@reaperrr reaperrr merged commit a586f10 into OpenRA:bleed Nov 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:backfired branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.