Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set duplicates flag for hotkeys in HokeyManager #17161

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@dragunoff
Copy link
Contributor

commented Sep 29, 2019

Follow up to #17079 (comment)

@dragunoff dragunoff force-pushed the dragunoff:fix/hotkey-manager-duplicates branch from 6bd92ee to b20b294 Sep 29, 2019
Copy link
Member

left a comment

Code changes look good.

OpenRA.Game/HotkeyDefinition.cs Outdated Show resolved Hide resolved
@dragunoff dragunoff force-pushed the dragunoff:fix/hotkey-manager-duplicates branch from b20b294 to db9d7c3 Sep 30, 2019
@dragunoff dragunoff force-pushed the dragunoff:fix/hotkey-manager-duplicates branch from db9d7c3 to 82fda68 Oct 2, 2019
@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Updated with a fix up.

@pchote pchote added this to the Next Release milestone Oct 5, 2019
@pchote

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Added to the milestone so we can ship the complete hotkey code.

@pchote
pchote approved these changes Oct 5, 2019
@pchote pchote added the PR: Needs +2 label Oct 5, 2019
@abcdefg30 abcdefg30 merged commit ad02adf into OpenRA:bleed Oct 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.