Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a lua exception when setting an owner to null/nil #17163

Merged
merged 1 commit into from Oct 19, 2019

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Oct 1, 2019

Closes #14224.

We already prevent setting an invalid OwnerInit.

Copy link
Member

cjshmyr left a comment

Works, maybe put quotes around the tostringed actor? Shows as:

Attempted to change the owner of actor dome 8 to nil value.

@cjshmyr cjshmyr added the PR: Needs +2 label Oct 2, 2019
@cjshmyr cjshmyr dismissed their stale review Oct 2, 2019

Accidental approval.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:nullOwner branch from 5e52d34 to 543d0f5 Oct 2, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Oct 2, 2019

Good idea, updated.

@reaperrr reaperrr merged commit fdd3bff into OpenRA:bleed Oct 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:nullOwner branch Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.