Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip MoveIntoWorld creation activity for map-placed Mobile actors #17187

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@pchote
Copy link
Member

commented Oct 6, 2019

Fixes #17184.

This PR follows the approach of SkipMakeAnimations to disable the activity in the remaining case that we know to be broken and can easily test. This is less risky than my original request from #16938 to make production / transports / etc explicitly request MoveIntoWorld, but we should move to that if any further regressions become obvious.

Depends on #17133.

@pchote pchote added this to the Next Release milestone Oct 6, 2019
@pchote pchote requested review from abcdefg30 and tovl Oct 6, 2019
@pchote pchote force-pushed the pchote:fix-ttnk-undeploy branch from f59a9a8 to 793f97e Oct 6, 2019
@pchote pchote force-pushed the pchote:fix-ttnk-undeploy branch from 793f97e to e78c0fc Oct 6, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

Dependency has been merged.

@pchote pchote force-pushed the pchote:fix-ttnk-undeploy branch from e78c0fc to f0c28cc Oct 6, 2019
Copy link
Contributor

left a comment

Rebased on #16947 to confirm the fix, didn't spot any obvious issues.

@tovl
tovl approved these changes Oct 6, 2019
@pchote pchote added the PR: Needs +2 label Oct 6, 2019
@abcdefg30 abcdefg30 merged commit 5eaa998 into OpenRA:bleed Oct 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.