Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the spectator UI being too wide #17188

Merged
merged 4 commits into from Oct 13, 2019

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Oct 6, 2019

Closes #17059. (Together with #17055.)

@abcdefg30 abcdefg30 added this to the Next Release milestone Oct 6, 2019
@abcdefg30 abcdefg30 force-pushed the abcdefg30:fewPx branch from d57a8ab to 4e86a92 Oct 6, 2019
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 6, 2019

The TD Economy and Combat panels and the two graphs still overlap with the scrollbar enabled.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:fewPx branch 2 times, most recently from f41553a to cb6db9b Oct 7, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Oct 7, 2019

Updated. This is now completely based on #17055.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 9, 2019

RA AI names run off the side of the graph background:

Screenshot 2019-10-09 at 20 45 36

Otherwise LGTM, good work slogging through all the changes here 👍

Copy link
Contributor

matjaeck left a comment

LGTM, the text overflow issue does not occur on my screen (<pchote> could be related to hidpi).

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Oct 11, 2019

Needs rebase now.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:fewPx branch from cb6db9b to f40ba43 Oct 13, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Oct 13, 2019

Rebased and updated.

@pchote
pchote approved these changes Oct 13, 2019
Copy link
Member

pchote left a comment

LGTM in all four mods at min res.

@pchote pchote added the PR: Needs +2 label Oct 13, 2019
@reaperrr reaperrr merged commit 1d90e08 into OpenRA:bleed Oct 13, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:fewPx branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.