Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Mobile's CanEnterCell consider ToSubCell: Prep edition #17223

Merged
merged 3 commits into from Oct 19, 2019

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Oct 12, 2019

See #17222. This is just based on prep and on the milestone.

OpenRA.Mods.Common/Traits/Air/Aircraft.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Crates/Crate.cs Outdated Show resolved Hide resolved
@abcdefg30 abcdefg30 force-pushed the abcdefg30:prep-SubCell branch from 524618f to 919427b Oct 18, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Oct 18, 2019

Added comments.

@teinarss

This comment has been minimized.

Copy link
Contributor

teinarss commented Oct 19, 2019

@pchote
pchote approved these changes Oct 19, 2019
OpenRA.Game/Traits/TraitsInterfaces.cs Outdated Show resolved Hide resolved
@abcdefg30 abcdefg30 force-pushed the abcdefg30:prep-SubCell branch from 919427b to 9eb3563 Oct 19, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Oct 19, 2019

Updated.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:prep-SubCell branch 2 times, most recently from fc5f852 to 87fca25 Oct 19, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Oct 19, 2019

Updated again.

@pchote pchote dismissed their stale review Oct 19, 2019

question

@abcdefg30 abcdefg30 force-pushed the abcdefg30:prep-SubCell branch from 87fca25 to 1d39aa8 Oct 19, 2019
@pchote
pchote approved these changes Oct 19, 2019
Copy link
Member

pchote left a comment

No meaningful code changes since my last 👍

@pchote pchote merged commit 5cd6744 into OpenRA:prep-1908 Oct 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote

This comment has been minimized.

@abcdefg30 abcdefg30 deleted the abcdefg30:prep-SubCell branch Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.