Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlaceDefenseTowardsEnemyChance trait to BaseBuilderBotModule #17236

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@blackhand1001
Copy link
Contributor

blackhand1001 commented Oct 16, 2019

Add PlaceDefenseTowardsEnemyChance trait to basebuilderbotmodule. This defaults to 100 which is the current behavior. This change now allows you to set the chance that bots will place defenses evenly around the base like the AI in stock red alert and Tiberian sun did.

@blackhand1001

This comment has been minimized.

Copy link
Contributor Author

blackhand1001 commented Oct 16, 2019

Here is a comparison of the two modes:

True:
OpenRA-2019-10-16T005255498Z

False:
OpenRA-2019-10-16T003934916Z

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 16, 2019

Do we want to use the new settings and tweak the AIs in this PR, or leave it to a follow-up?

@blackhand1001

This comment has been minimized.

Copy link
Contributor Author

blackhand1001 commented Oct 16, 2019

I'll do a seperate PR for the AI modules. I need to tweak the ratio of defenses up a bit higher since now they will be built all around the base.

Copy link
Member

abcdefg30 left a comment

Code changes look good to me after the one comment below is resolved. Please squash the commits together as well.

Add PlaceDefenseTowardsEnemyChance trait to basebuilderbotmodule. This defeaults to 100 which is the current behavior. This change now allows you to set the chance that bots will place defenses evenly around the base like the AI in stock red alert and Tiberian sun did.
@blackhand1001 blackhand1001 force-pushed the blackhand1001:basebuilder branch from 4910b29 to 3796592 Oct 22, 2019
@blackhand1001

This comment has been minimized.

Copy link
Contributor Author

blackhand1001 commented Oct 22, 2019

This should be good to go. Added the full stop and squashed the commits.

@blackhand1001 blackhand1001 changed the title Add PlaceDefensesTowardsEnemyBase trait to BaseBuilderBotModule Add PlaceDefenseTowardsEnemyChance trait to BaseBuilderBotModule Oct 23, 2019
@blackhand1001 blackhand1001 requested a review from pchote Oct 23, 2019
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 24, 2019

Looks reasonable at a quick look, but I'm not going to be able to test this any time soon.

Copy link

ghost left a comment

Works as expected and LGTM after it's decided if BuildingType should be renamed or not.

@reaperrr reaperrr mentioned this pull request Nov 3, 2019
16 of 16 tasks complete
@ghost
ghost approved these changes Nov 5, 2019
Copy link

ghost left a comment

Renaming can be done in the eventual refactor of the module.

@teinarss teinarss merged commit 780982d into OpenRA:bleed Nov 6, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.