Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17230: Dummy audio output class #17245

Merged
merged 1 commit into from Nov 14, 2019
Merged

Fix #17230: Dummy audio output class #17245

merged 1 commit into from Nov 14, 2019

Conversation

@abmyii
Copy link
Contributor

abmyii commented Oct 17, 2019

The easiest method that I thought of as a solution was to make a dummy audio engine, which I did. I stripped the OpenAL engine down to the smallest I could and then used a try-catch to select the dummy in case of an error.
Test case is to run OpenRA over SSH using VirtualGL - niche, I know, but this will also help in cases where audio systems fail causing the whole game to not work.

Closes #17230.
Closes #12300.

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Oct 19, 2019

Workaround for #12300.

@abmyii

This comment has been minimized.

Copy link
Contributor Author

abmyii commented Oct 19, 2019

Even better! Thanks for referencing it.

@abmyii

This comment has been minimized.

Copy link
Contributor Author

abmyii commented Oct 20, 2019

Any updates?

@abmyii

This comment has been minimized.

Copy link
Contributor Author

abmyii commented Oct 28, 2019

Ping.

OpenRA.Platforms.Default/DummySoundEngine.cs Outdated Show resolved Hide resolved
OpenRA.Platforms.Default/DummySoundEngine.cs Outdated Show resolved Hide resolved
OpenRA.Platforms.Default/DummySoundEngine.cs Outdated Show resolved Hide resolved
@abmyii abmyii force-pushed the abmyii:dummy_openal branch 2 times, most recently from 0bd75bf to b89d030 Oct 28, 2019
@abmyii abmyii force-pushed the abmyii:dummy_openal branch 2 times, most recently from bf6620b to 5327c65 Nov 7, 2019
@abmyii abmyii force-pushed the abmyii:dummy_openal branch from 5327c65 to 8a32d51 Nov 8, 2019
@abmyii abmyii force-pushed the abmyii:dummy_openal branch from 8a32d51 to 355e67a Nov 8, 2019
@abmyii abmyii requested a review from teinarss Nov 9, 2019
@abmyii

This comment has been minimized.

Copy link
Contributor Author

abmyii commented Nov 12, 2019

Any updates?

OpenRA.Game/Sound/Sound.cs Outdated Show resolved Hide resolved
Copy link
Contributor

reaperrr left a comment

Looks good to me otherwise.

@abmyii abmyii force-pushed the abmyii:dummy_openal branch from 355e67a to 96dfb60 Nov 14, 2019
@abmyii abmyii requested review from abcdefg30 and pchote Nov 14, 2019
@abcdefg30 abcdefg30 merged commit 72eb4e1 into OpenRA:bleed Nov 14, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Nov 14, 2019

@abmyii

This comment has been minimized.

Copy link
Contributor Author

abmyii commented Nov 14, 2019

Awesome, thanks to everyone who helped and reviewed!

@reaperrr reaperrr mentioned this pull request Nov 23, 2019
12 of 19 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.