Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow carryall pickup orders on deployed vehicles (prep edition) #17254

Merged
merged 4 commits into from Oct 19, 2019

Conversation

@pchote
Copy link
Member

pchote commented Oct 19, 2019

#17221 rebased and adapted for the prep branch.

The changes compared with the original PR are:

  • Removed BlockedByActor.Immovable from Move.EvalPath - related to #16408, changes in EvalPath do not impact this PR.
  • Changed MoveFirstHalf.OnComplete to call IsTurn with two args instead of three - related to #16408, changes in EvalPath do not impact this PR.
  • Replaced FlyIdle with FlyCircle and dropped the FlyIdle changes - This changes the carryall behaviour in TS (it circles instead of hovers), but this IMO is a perfectly reasonable tradeoff vs implementing custom code that won't actually be used.
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Oct 19, 2019

The changes compared to bleed version are IMO small enough that this doesn't need a +2.

@reaperrr reaperrr merged commit 5b19dbe into OpenRA:prep-1908 Oct 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.