Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AmmoPool lookup methods with properties #17255

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@reaperrr
Copy link
Contributor

reaperrr commented Oct 19, 2019

And gave them more suitable names while at it.

This is more in line with how we do things in other places.

@reaperrr reaperrr force-pushed the reaperrr:polish-ammopool branch from 058f526 to ead5cff Oct 19, 2019
@reaperrr reaperrr mentioned this pull request Nov 17, 2019
Copy link
Member

penev92 left a comment

I'd rename CurrentAmmo to CurrentAmmoCount and I'd switch the two new boolean properties' order, but neither of those is a deal-breaker.
👍

And gave the more suitable names while at it.
This is more in line with how we do things in
other places.
@reaperrr reaperrr force-pushed the reaperrr:polish-ammopool branch from ead5cff to 85c42fa Nov 18, 2019
@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Nov 18, 2019

Updated.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Nov 20, 2019

IMO it's one of those PRs that don't really need a +2, and I adressed @penev92's nits so LGTM.

@reaperrr reaperrr merged commit ee00954 into OpenRA:bleed Nov 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr reaperrr deleted the reaperrr:polish-ammopool branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.