Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EjectOnDeath pilot spawning. #17287

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@pchote
Copy link
Member

pchote commented Oct 27, 2019

Fixes #17286 and cleans up some code quality issues.

Note that #17222 has not been merged to bleed yet, so the 5th-paratrooper-dies bug is still present and not related to this PR.

@pchote pchote added this to the Next Release milestone Oct 27, 2019
@pchote pchote force-pushed the pchote:fix-ejectondeath branch from 4b0eb97 to e7f9cf2 Oct 27, 2019
@tovl

This comment has been minimized.

Copy link
Contributor

tovl commented Oct 28, 2019

How does this relate to #16353?

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Oct 28, 2019

It doesn't, although some of the fixes in this could perhaps also be made there. This would need to be a separate PR.

@abcdefg30 abcdefg30 merged commit 230a0b3 into OpenRA:bleed Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.