Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix several issues with left-mouse orders #17291
This fixes #13723
It should be fairly obvious (unless i'm missing something) that doing any kind of filtering here is wrong. If any unit in the selection has a valid order then that should take priority over selecting the target, regardless of any selection priorities or distances.
Also fixes #12922.
This has the side effect that you can no longer give a move order at a location with a selected actor without using force move.
In original RA, the move-blocked cursor is shown when pointing at cells with already selected units or when the cell is occupied / blocked. Select seems to be used for unselected selectables unless there are orders against the target / cell (attack, move-blocked, enter).
These mod- specific cursor details are probably out of the scope of fixing the bug so I think it's enough to restore the old behavior for move orders on selected units.
Edit: This is not a change so unrelated to this PR.