Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix McvManagerBotModule spamming deploy orders #17321
Removes the 'activeMCVs' list since it was not useful. The real bugfix is not iterating over 'activeMCVs' when issueing new orders (this was previously needed for already discovered mcvs that stopped) but over 'newMCVs' instead.
I really can't believe this is causing anything significant (we actually only reduced enumerations). Are you sure this isn't more likely to be caused - if at all  - by the second PR he linked (#16347)? (: Actually I'm not even sure if I trust this method of performance measuring.)
I just ran a 10-minute AI game (6 AIs, maximum speed) and
Yes, should not, but does. It changes much of the support power related code and even take cover and the changes in general are much less clear than in this PR - if one of those is really responsible it is more likely we overlooked something in #16347 than here.