Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn ejected pilots inside a FrameEndTask. #17342

Merged
merged 1 commit into from Nov 16, 2019
Merged

Conversation

@pchote
Copy link
Member

pchote commented Nov 16, 2019

Fixes #17341 by moving all of the spawning logic inside a FrameEndTask. This keeps the original intention from #17287 of not spawning the actor and then destroying it after we find its not valid.

@pchote pchote added this to the Next Release milestone Nov 16, 2019
@pchote pchote force-pushed the pchote:fix-eject-crash branch from 4620bf2 to 77cef44 Nov 16, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Nov 16, 2019

Fixed the StyleCop issue.

Copy link
Contributor

matjaeck left a comment

Testing did not reveal any issues.

@abcdefg30 abcdefg30 merged commit 6b1e81a into OpenRA:bleed Nov 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Nov 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.