Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsDead check to FerryUnit OnFirstRun #17353

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@teinarss
Copy link
Contributor

teinarss commented Nov 18, 2019

Fixes the crash reported in #17076 (comment)

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Nov 18, 2019

Do you have a reproduction case?

@teinarss

This comment has been minimized.

Copy link
Contributor Author

teinarss commented Nov 18, 2019

@tovl
tovl approved these changes Nov 19, 2019
@reaperrr reaperrr merged commit c77aa4c into OpenRA:bleed Nov 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 23, 2019

This hasn't been picked to prep yet. Should we, considering #17500?

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 23, 2019

Yeah, I think so. It was already listed in #17307, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.