Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ShpD2 and TmpRA/TD loaders to Mods.Cnc #17358

Merged
merged 1 commit into from Dec 1, 2019

Conversation

@reaperrr
Copy link
Contributor

reaperrr commented Nov 18, 2019

Split from #17355.

Reducing the count of proprietary formats in Mods.Common.

Note: Moving ShpD2 to Mods.Cnc is intentional. RA/TD use it for their original mouse shp files, and any D2(k) mod will normally need Mods.Cnc anyway, while we can avoid adding a Mods.D2k dependency to RA/TD this way.

Reducing the count of proprietary formats in Mods.Common.

Note: Moving ShpD2 to Mods.Cnc is intentional. RA/TD
use it for their original mouse shp files, and any D2(k) mod
will normally need Mods.Cnc anyway, while we can avoid
adding a Mods.D2k dependency to RA/TD this way.
@reaperrr reaperrr force-pushed the reaperrr:move-WW-formats-pt2 branch from a297663 to 08005e4 Nov 29, 2019
@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Nov 29, 2019

Small update, the usings of OpenRA.Mods.Common.SpriteLoaders were redundant.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Dec 1, 2019

Considering the nature of this PR and discussions on IRC, I don't think this absolutely needs another approval, so LGTM.

@reaperrr reaperrr merged commit a74235b into OpenRA:bleed Dec 1, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.