Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default LocalClientId in ReplayConnection to -1 #17382

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Nov 24, 2019

We do not have a local client in replays. This change prevents anything from accidentally using (sometimes there might be clients with ID 0 present), e.g. #17381.

I checked all uses of LocalClientId and this should be fine, but think it's better not to put this on the hotfix release.

We do not have a local client in replays.
This change prevents anything from accidentally using (sometimes there might be clients with ID 0 present).
@pchote
pchote approved these changes Jan 12, 2020
@pchote pchote added the PR: Needs +2 label Jan 12, 2020
@reaperrr reaperrr merged commit a28992a into OpenRA:bleed Jan 12, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:minusReplay branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.