Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old visibility recalc frequency (Prep Edition) #17397

Merged
merged 1 commit into from Dec 8, 2019

Conversation

@reaperrr
Copy link
Contributor

reaperrr commented Nov 29, 2019

The increased recalc frequency has shown to cause serious performance issues with fast-moving units like aircraft.
Disabling it for aircraft in the hotfix release.

Filed directly against prep.

Fixes #17377 for prep.

@reaperrr reaperrr added this to the Next Release milestone Nov 29, 2019
@reaperrr reaperrr mentioned this pull request Nov 29, 2019
16 of 16 tasks complete
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 29, 2019

We only want to disable this for aircraft, which are a problem because they move fast and have a huge vision radius. For normal ground-based units the overhead is smaller and worth it for fixing the vision mismatch bug.

The logic has shown to cause serious performance issues
with fast movement.
Disabling it on aircraft for the hotfix release.
@reaperrr reaperrr force-pushed the reaperrr:prep-shroud-perf branch from 34a940c to 4ebf951 Nov 29, 2019
@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Nov 29, 2019

Updated.

@tovl
tovl approved these changes Nov 29, 2019
Copy link
Member

abcdefg30 left a comment

Ok for mitigation I guess. This shouldn't be too noticeable on aircraft anyway.

@abcdefg30 abcdefg30 merged commit 324d2ba into OpenRA:prep-1908 Dec 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Dec 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.