Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ProductionAirdrop & WithDeliveryAnimation to Mods.Common #17406

merged 3 commits into from Dec 8, 2019


Copy link

reaperrr commented Dec 1, 2019

Nearly all logic in Mods.Cnc is mod/game-specific or at least Westwood-specific enough that their placement in Mods.Cnc is accurate.

However, I feel ProductionAirdrop (and WithDeliveryAnimation) is a bit of an edge case by now, and one of the more likely traits to be used by non-C&C-based downstream mods which may otherwise not want/need to use Mods.Cnc (this does apply to one of my downstream projects, at least).

Removing the TD-specific c17 default from ActorType and making it FieldLoader.Require should be the only must-have prerequisite for moving it up to Mods.Common.

WithDeliveryAnimation is actually even ProductionAirdrop-agnostic, as it uses the INotifyDelivery interface only, which has been in Mods.Common for quite a while (this also means the animation can now be used together with ProductionParadrop without the need for Mods.Cnc).

Supersedes #17385.

Copy link

Mailaender left a comment

Less hard-coded actor types is always good.

pchote approved these changes Dec 8, 2019
@pchote pchote merged commit efc06a0 into OpenRA:bleed Dec 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.