Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a crash in AutoTarget.HasValidTargetPriority #17415

Merged
merged 2 commits into from Dec 14, 2019

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Dec 2, 2019

Fixes #17409.

This occurred when never saw the unit it was attacking and then had its stance changed.
The first commit makes HasValidTargetPriority more robust, while the second commit lets the caller account for the fact that lastVisibleOwner et al. can be null.

@abcdefg30 abcdefg30 added this to the Next Release milestone Dec 2, 2019
@abcdefg30 abcdefg30 force-pushed the abcdefg30:nullOwner branch from f398384 to 86b8174 Dec 3, 2019
@teinarss teinarss merged commit 1e138a9 into OpenRA:bleed Dec 14, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@teinarss

This comment has been minimized.

Copy link
Contributor

teinarss commented Dec 14, 2019

@abcdefg30 abcdefg30 deleted the abcdefg30:nullOwner branch Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.