Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cell triggers in sarin-gas-2 from firing several times #17420

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Dec 3, 2019

Closes #17402.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 28, 2019

I assume we want this for the hotfix, so adding to the milestone.

@pchote pchote added this to the Next Release milestone Dec 28, 2019
@pchote
pchote approved these changes Jan 2, 2020
Copy link
Member

pchote left a comment

I couldn't work out how to reproduce the original issue, but the changes here look sensible and a play-through of the mission shows that the new triggers still work correctly.

@pchote pchote added the PR: Needs +2 label Jan 2, 2020
@reaperrr reaperrr merged commit e1c07d3 into OpenRA:bleed Jan 12, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:sarin branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.