Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul cursor doubling feature #17435

Merged
merged 2 commits into from Dec 11, 2019
Merged

Overhaul cursor doubling feature #17435

merged 2 commits into from Dec 11, 2019

Conversation

@pchote
Copy link
Member

pchote commented Dec 8, 2019

This PR overhauls the cursor doubling feature in preparation for arbitrary zooming. The previous implementation was a limited hack, in that it only worked with software cursors, and only when pixel doubling is enabled.

The option now applies all the time when enabled (regardless of zoom state), except to the default pointer cursor - in both hardware and software cursor modes. This also fixes an issue with the pixel doubling code that meant we always fell back to software cursors on systems with >150% DPI scaling, and fixes the restart prompt not showing after changing the cursor settings.

Split from #17424 to simplify review and allow other PRs to be based on this.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 8, 2019

I suspect not everyone will be happy with the default cursor not doubling along the rest, though personally I don't really mind. Just pointing out that there might be some backlash, though I don't think cursor doubling is all that popular outside of retro feeling in singleplayer.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 8, 2019

I suspect not everyone will be happy with the default cursor not doubling along the rest, though personally I don't really mind.

My logic here was that the larger order cursors do IMO look like a much better match with the world at the larger zoom levels (which will be more important with #17424), but the pointer cursor looks plain ugly and unnecessarily large when interacting with everything else in the UI.

@teinarss teinarss merged commit b0c65c5 into OpenRA:bleed Dec 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 4, 2020

Added c66a01a to prep as per #17517 (comment).

@pchote pchote deleted the pchote:cursor-doubling branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.