Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore NukePower support for proxy actors. #17457

Merged
merged 1 commit into from Dec 14, 2019
Merged

Conversation

@pchote
Copy link
Member

pchote commented Dec 14, 2019

Fixes #17458.

Testcase: apply a97a807 and build a refinery.

@@ -16,7 +16,7 @@

namespace OpenRA.Mods.Common.Traits
{
class NukePowerInfo : SupportPowerInfo, IRulesetLoaded, Requires<BodyOrientationInfo>

This comment has been minimized.

Copy link
@pchote

pchote Dec 14, 2019

Author Member

The IRulesetLoaded removal isn't part of the fix, but it was redundant because we inherit from SupportPowerInfo.

Copy link
Member

MustaphaTR left a comment

Testcase works fine.

@abcdefg30 abcdefg30 merged commit 3487846 into OpenRA:bleed Dec 14, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Dec 14, 2019

@pchote pchote deleted the pchote:fix-nukeproxy branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.