Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve discoverability of dummy sound device #17470
This PR expands on #17245 to make it more obvious to players why their sound isn't working when the dummy sound device is active.
The first commit renames the sound device exposed in the settings.
If the second commit is considered weird, I could instead display a label warning that the sound is disabled so changing them won't do anything, and find a different fix to whatever the mute code was trying to do.
Probably out of scope for this PR, but: The 'disabled' feedback of the volume sliders sucks. Rather, other than being immovable, there's no visible indicator that they're disabled at all, not even greyed out text.
Otherwise looks good, @pchote if you'd prefer to see this merged as-is for now, I'd be ok with that.
The main reason is that I have a deep tree with multiple branches all based on #17489, and I really don't want to deal with resolving the rebase conflict this would cause several times over.
If we wait for #17489 I can make the change in the new syntax for bleed, then file a separate PR with the legacy format for prep.