Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare RA chrome for fractional DPI/UI scaling #17495

Merged
merged 1 commit into from Jan 12, 2020
Merged

Conversation

@pchote
Copy link
Member

pchote commented Dec 22, 2019

This PR is a sibling to #17494, which outlines the motivations and requirements, and gives some hints on how to efficiently test and review this.

RA is split into its own PR as it is a much larger rework than TD or the content installer.

The previous chrome.png is split into two new files, with glyphs.png generated from SVG at multiple resolutions and sidebar.png holding the native pixel-based data (with significantly reduced duplication).

The loadscreen has also been rebuilt and generated from SVG.

This also has to touch the music icon mappings in D2k and TS because of changes to the common widget layout.

Depends on #17489.
Artwork source are PRed in: OpenRA/ArtSrc#8.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 24, 2019

Updated to fix a tiling error with dialog.

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Dec 24, 2019

Looking good. I see you've added active states for command icons but for some reason "deploy", "scatter" and "stop" don't flash the active icon (like in TD for example). It might even be better that way but I'm curious why it happens?

@pchote pchote force-pushed the pchote:render-raui branch from 2b1c916 to 56297c6 Dec 25, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 25, 2019

Good eye! The change to the active states weren't intentional - fixed.

@pchote pchote force-pushed the pchote:render-raui branch 2 times, most recently from df00cf7 to 439e096 Dec 25, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 28, 2019

Updated to remove the vestigial debug menu button from the sidebar, which was causing a crash when starting a game with the debug menu lobby option checked. We don't have vector artwork for this glyph, and the effort to create a new one from scratch isn't justified by saving a mouse click when most of us use the chat commands.

@pchote pchote force-pushed the pchote:render-raui branch from 439e096 to f32d5d9 Dec 28, 2019
@pchote pchote removed the PR: Rebase me! label Dec 28, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 28, 2019

Rebased.

@pchote pchote force-pushed the pchote:render-raui branch from f32d5d9 to 789b858 Dec 28, 2019
Copy link
Contributor

dragunoff left a comment

Looks good in-game.

I think the RA sidebar and dialogs can be recreated in SVG without too much effort. In a future PR of course. I may look into that.

@pchote pchote force-pushed the pchote:render-raui branch from e857471 to 3cccd63 Jan 8, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 8, 2020

Rebased and updated with a glyph for #17549.

mods/ra/chrome.yaml Outdated Show resolved Hide resolved
@pchote pchote force-pushed the pchote:render-raui branch from 3cccd63 to 2a7c365 Jan 12, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 12, 2020

Fixed.

@abcdefg30 abcdefg30 merged commit 1282650 into OpenRA:bleed Jan 12, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 12, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.