Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming in editor #17496

Merged
merged 1 commit into from Jan 11, 2020
Merged

Fix naming in editor #17496

merged 1 commit into from Jan 11, 2020

Conversation

@teinarss
Copy link
Contributor

teinarss commented Dec 23, 2019

Fixes #17493

Copy link
Member

Mailaender left a comment

Fix confirmed.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 7, 2020

I haven't wrapped my head around the specific details of the undo/redo support yet - can you describe why we want to Do() EditActorEditorAction here but not the options?

@teinarss

This comment has been minimized.

Copy link
Contributor Author

teinarss commented Jan 7, 2020

I haven't wrapped my head around the specific details of the undo/redo support yet - can you describe why we want to Do() EditActorEditorAction here but not the options?

The options (e.g. health, facing, turret etc) are set directly on the actor as these are manipulated in real time when the user changes these values, in the edit actor dialog. This was done to keep the "preview" working.

Updating the actor's ID is only done when clicking OK in the dialog.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 7, 2020

Would it make sense to apply the ID changes when the text field loses focus? This would make it consistent with the other options, right?

@teinarss

This comment has been minimized.

Copy link
Contributor Author

teinarss commented Jan 7, 2020

Would it make sense to apply the ID changes when the text field loses focus? This would make it consistent with the other options, right?

Not sure its worth it. The whole edit actor feature is a bit messy atm and a rewrite would be better.

@pchote
pchote approved these changes Jan 11, 2020
@pchote pchote merged commit 43eabdf into OpenRA:bleed Jan 11, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.