Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render editor cursor previews as part of the world #17509

Merged
merged 3 commits into from Jan 12, 2020

Conversation

@pchote
Copy link
Member

pchote commented Dec 26, 2019

This PR fixes the rendering glitches (too-smooth voxels, gaps between terrain tiles, the turret positioning issue noted in #17431, plus some others that would be introduced by the UI scaling options) which are currently caused by rendering these in the UI layer.

Required for #10382.

@pchote pchote added this to the Next+1 milestone Dec 26, 2019
@pchote pchote force-pushed the pchote:render-editorcursors branch from 15b6a3a to 70f4c36 Dec 27, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 27, 2019

Rebased and fixed actor bibs drawing above buildings in the preview.

@pchote pchote force-pushed the pchote:render-editorcursors branch from 70f4c36 to 1ed2418 Dec 28, 2019
@@ -265,6 +265,7 @@ World:
EditorWorld:
Inherits: ^BaseWorld
EditorActorLayer:
EditorCursorLayer:

This comment has been minimized.

Copy link
@Mailaender

Mailaender Jan 3, 2020

Member

I guess this needs an update rule.

This comment has been minimized.

Copy link
@pchote

pchote Jan 3, 2020

Author Member

Update rules aren’t able to do these kind of changes. It will need to be added to https://github.com/OpenRA/OpenRAModSDK/wiki/Update-notes:-hotfix-release-to-next-release instead.

Copy link
Member

Mailaender left a comment

Editor works fine across mods.

@pchote pchote force-pushed the pchote:render-editorcursors branch from 1ed2418 to 0898c2d Jan 12, 2020
@pchote pchote force-pushed the pchote:render-editorcursors branch from 0898c2d to 173d8ce Jan 12, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 12, 2020

Updated.

Copy link
Member

abcdefg30 left a comment

Ok.

@abcdefg30 abcdefg30 merged commit cc05621 into OpenRA:bleed Jan 12, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 12, 2020

@pchote pchote deleted the pchote:render-editorcursors branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.