Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TakeCover fixes #17522

Merged
merged 2 commits into from Dec 30, 2019
Merged

TakeCover fixes #17522

merged 2 commits into from Dec 30, 2019

Conversation

@reaperrr
Copy link
Contributor

reaperrr commented Dec 30, 2019

Makes TakeCover properly disableable, renames ProneTime to Duration and adds two property descriptions.

Split from #17264 to hopefully make the latter's diff less off-putting.

reaperrr added 2 commits Oct 21, 2019
Speed and Damage modifiers were ignoring IsTraitDisabled.
More in line with our property naming conventions.

Additionally, added descs to ProneOffset and
ProneSequencePrefix, since at  least the purpose of
the former isn't entirely clear without looking at the code.
@pchote
pchote approved these changes Dec 30, 2019
Copy link
Member

pchote left a comment

LGTM.

Behaves as expected when adding

GrantConditionOnDeploy:
	DeployedCondition: noprone
TakeCover:
	RequiresCondition: !noprone

to the TD e1.

@pchote pchote added the PR: Needs +2 label Dec 30, 2019
@Mailaender Mailaender merged commit 037ce9e into OpenRA:bleed Dec 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Copy link
Member

Mailaender commented Dec 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.