Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic GeoIP download from the build scripts. #17530

Merged
merged 2 commits into from Dec 31, 2019

Conversation

@pchote
Copy link
Member

pchote commented Dec 31, 2019

This PR implements a quick first step towards #17529, removing the database fetching so people/robots can at least compile the project again. I have kept the references in the packaging script for now (which is why AppVeyor is still failing) because I expect that the solution for the prep branch will be to ship the file.

The game is already set up to gracefully fail back to showing "Unknown Location" if the database is missing. A followup PR will be needed to fix the ingame behaviour after we decide on an approach in #17529.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 31, 2019

We should hold off merging any other PRs to bleed before this one, to avoid breaking the build on bleed.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 31, 2019

Added a second commit to remove the database from install/packaging. This should be merged to bleed but not picked to prep.

Once this has been merged I (or someone else) can push a commit straight to prep that adds https://github.com/flathub/net.openra.OpenRA/blob/master/GeoLite2-Country.mmdb.gz to the root of the repo.

@abcdefg30 abcdefg30 merged commit adf1c0b into OpenRA:bleed Dec 31, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Dec 31, 2019

First commit:
Changelog
e31bcd3

Second commit (not on prep):
Changelog

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 31, 2019

#17535 fixes an omission and f5e4c1d adds the last license-compatible version of the GeoIP database to prep.

A test build of prep packages and runs without error - although I can't test the GeoIP feature itself due to the master server being down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.