Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nearEnough destination handling. #17541

Merged
merged 1 commit into from Feb 18, 2020

Conversation

@pchote
Copy link
Member

pchote commented Jan 1, 2020

From a gameplay perspective, the problem with the nearEnough logic is that units give up and stop in cases where it is blindingly obvious to the player that they should have done better. Reducing or dynamically rescaling the nearEnough range reduces the chance of these cases happening, but the easier (and IMO smarter) solution is to directly target and reduce/solve those specific obvious cases.

This PR implements a simple check to makes #17531 (comment) work properly when the blocking actor is within nearEnough of the destination. This should also help more generally with #5968.

This could be expanded in future PRs to add more checks or dynamic repathing such as 11d7eac.

I've made this depend on #17531 because there is no point testing this one without the fixes there. There is no actual code dependency on that or the other bleed-only pathing changes, so if the concept here passes review we can (should?) also pick this to prep.

@pchote pchote requested a review from tovl Jan 1, 2020
@pchote pchote force-pushed the pchote:improve-nearenough-assertiveness branch from 057f0b4 to d407caf Jan 1, 2020
MustaphaTR added a commit to ABrandau/OpenRA that referenced this pull request Jan 14, 2020
@pchote pchote added this to the Next+1 milestone Jan 26, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Feb 12, 2020

@MustaphaTR the timeline above shows that this was pulled in to SP about a month ago. Can you confirm that this didn't cause any issues there and leave a review?

Copy link
Member

MustaphaTR left a comment

I'm not aware of any regression that may be caused by this in SP. This was implemented in SP to fix that while (a-)moving units didn't spread properly and create a straigt line.

@pchote pchote added the PR: Needs +2 label Feb 12, 2020
@pchote pchote force-pushed the pchote:improve-nearenough-assertiveness branch from d407caf to 92dc15b Feb 12, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Feb 12, 2020

Rebased.

@pchote pchote force-pushed the pchote:improve-nearenough-assertiveness branch from 92dc15b to 735edb7 Feb 17, 2020
@pchote pchote force-pushed the pchote:improve-nearenough-assertiveness branch from 735edb7 to f30e51d Feb 17, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Feb 17, 2020

Updated (first push) and rebased (second push).

@pchote pchote requested a review from abcdefg30 Feb 17, 2020
@teinarss teinarss merged commit 9a66026 into OpenRA:bleed Feb 18, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.