Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore MODIFIER_OVERRIDES handling of unmodified attack move hotkey. #17552

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@pchote
Copy link
Member

pchote commented Jan 3, 2020

This PR implements a simple speculative fix for #17438.

I am not able to reproduce the original issue, so cannot test this myself. Ping @Orb370 and @dragunoff to confirm whether this helps.

There is a strong chance that the PR as it currently stands won't work - I suspect that the underlying issue may be related to filtering out KeyInputEvent.Up, which was previously handled by MODIFIER_OVERRIDES but never by ButtonWidget. If this is the case, and we decide that we want to work around it despite it being user-error, then that is an extra 1 line tweak.

@pchote pchote added this to the Next Release milestone Jan 3, 2020
@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Jan 3, 2020

I'm still able to reproduce the bug. But I'd feel better if someone else can reproduce it as well.

@pchote pchote force-pushed the pchote:fix-attackmove-input branch from ad1edd5 to 9fbff95 Jan 3, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 3, 2020

Updated to restore the key up handling.

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Jan 4, 2020

Updated to restore the key up handling.

I confirm that after that I'm no longer able to reproduce the bug.

@abcdefg30 abcdefg30 merged commit 524e887 into OpenRA:bleed Jan 12, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 12, 2020

@pchote pchote deleted the pchote:fix-attackmove-input branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.