Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client-side GeoIP and anonymise shared IPs #17575

Merged
merged 6 commits into from Jan 15, 2020
Merged

Conversation

@pchote
Copy link
Member

pchote commented Jan 11, 2020

This PR:

  • Moves the GeoIP country lookup from the game client to an opt-in server feature.
  • Anonymises client IPs before sharing them with other players.
  • Allows server hosts to opt out of sharing IPs completely.

https://github.com/OpenRA/OpenRA/wiki/Dedicated will need to be updated to reference https://dev.maxmind.com/geoip/geoipupdate/ once we are ready to ship the Next + 1 playtests.

Closes #17529.
Closes #15647.
Closes #17343.
Closes #17534.

@pchote pchote added this to the Next+1 milestone Jan 11, 2020
@pchote pchote force-pushed the pchote:fix-geoip branch 2 times, most recently from d363854 to 020ebd3 Jan 11, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 11, 2020

Updated to fix several nits @abcdefg30 raised in IRC.

OpenRA.Game/Server/Server.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Widgets/Logic/ServerListLogic.cs Outdated Show resolved Hide resolved
Copy link
Member

Mailaender left a comment

Sounds like a good compromise.

AUTHORS Show resolved Hide resolved
@pchote pchote force-pushed the pchote:fix-geoip branch from 020ebd3 to 3e33596 Jan 12, 2020
@pchote pchote force-pushed the pchote:fix-geoip branch from 3e33596 to a42e1b1 Jan 12, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 12, 2020

Updated.

Copy link
Member

abcdefg30 left a comment

Imho we should add a ShareAnonymizedIPs=True default to the dedicated launcher scripts, like we do for EnableSingleplayer. Lgtm otherwise.

@pchote pchote force-pushed the pchote:fix-geoip branch from a42e1b1 to 38c7592 Jan 14, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 14, 2020

Updated.

@abcdefg30 abcdefg30 merged commit d643685 into OpenRA:bleed Jan 15, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 15, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.