Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let all Positionable traits notify visual position changes #17585

Merged
merged 1 commit into from Jan 18, 2020

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Jan 15, 2020

Fixes a regression from #17383 that causes boats in TD to not reveal any shroud. Testcase is GDI01.

@abcdefg30 abcdefg30 mentioned this pull request Jan 15, 2020
@abcdefg30 abcdefg30 added this to the Next+1 milestone Jan 15, 2020
Copy link
Contributor

fruestueck left a comment

Works as intended. Tested with GDI1 (and PR for GDI9)

@pchote
pchote approved these changes Jan 18, 2020
@pchote pchote merged commit 15b2d6b into OpenRA:bleed Jan 18, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:tdBoat branch Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.