Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix subcell crusher logic. #17618
Did notice while testing that not the whole squad will move to the cell. Often one or more will stay at the previous cell.…
On Sun, Jan 26, 2020, 14:25 Paul Chote ***@***.***> wrote: This PR cleans up the last pieces missed by #17222 <#17222> to fix #4826 <#4826>. ------------------------------ You can view, comment on, or merge this pull request online at: #17618 Commit Summary - Fix subcell crusher logic. File Changes - *M* OpenRA.Mods.Common/Traits/Mobile.cs <https://github.com/OpenRA/OpenRA/pull/17618/files#diff-0> (2) - *M* OpenRA.Mods.Common/Traits/World/Locomotor.cs <https://github.com/OpenRA/OpenRA/pull/17618/files#diff-1> (4) Patch Links: - https://github.com/OpenRA/OpenRA/pull/17618.patch - https://github.com/OpenRA/OpenRA/pull/17618.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17618?email_source=notifications&email_token=AESI7GEYY73MIQJ7IWDMIX3Q7WFNRA5CNFSM4KLW4I72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIYDO6A>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AESI7GEILKZEPYDICKXWU43Q7WFNRANCNFSM4KLW4I7Q> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.