Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subcell crusher logic. #17618

Merged
merged 1 commit into from Feb 9, 2020
Merged

Fix subcell crusher logic. #17618

merged 1 commit into from Feb 9, 2020

Conversation

@pchote
Copy link
Member

pchote commented Jan 26, 2020

This PR cleans up the last pieces missed by #17222 to fix #4826.

@pchote pchote added this to the Next+1 milestone Jan 26, 2020
@teinarss

This comment has been minimized.

Copy link
Contributor

teinarss commented Jan 26, 2020

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 26, 2020

Are you sure that isn't the standard bogus nearenough behaviour that #17541 aims to fix?

Edit: my tests show that the stragglers are being blocked by other infantry, so this must be the case.

Copy link
Member

Mailaender left a comment

Looks sane.

@reaperrr reaperrr merged commit 85a5b6c into OpenRA:bleed Feb 9, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote pchote deleted the pchote:fix-subcell-crushing branch Feb 15, 2020
@pchote pchote mentioned this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.