Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sequence checks being too strict and nicer infantry zaps #17627

Merged
merged 8 commits into from Feb 23, 2020

Conversation

@Mailaender
Copy link
Member

Mailaender commented Jan 27, 2020

Closes #16576 and we can keep the test cases.
Fixes #17646 as well.

@Mailaender Mailaender force-pushed the Mailaender:less-strict-frame-sequences branch from 8002967 to 8b26f1b Jan 27, 2020
@Mailaender Mailaender force-pushed the Mailaender:less-strict-frame-sequences branch from 8b26f1b to 163a8e1 Feb 22, 2020
Copy link
Member

pchote left a comment

Basic approach looks good, just a couple of issues.

This adds some nice polish and fixes two frustrating modding issues, so IMO we should take this for the playtest.

OpenRA.Mods.Common/Graphics/DefaultSpriteSequence.cs Outdated Show resolved Hide resolved
mods/ra/sequences/infantry.yaml Outdated Show resolved Hide resolved
mods/ra/sequences/infantry.yaml Outdated Show resolved Hide resolved
mods/ts/sequences/infantry.yaml Outdated Show resolved Hide resolved
@pchote pchote added this to the Next Release milestone Feb 22, 2020
@Mailaender Mailaender force-pushed the Mailaender:less-strict-frame-sequences branch from 3229285 to 500c63b Feb 22, 2020
@Mailaender Mailaender force-pushed the Mailaender:less-strict-frame-sequences branch from 500c63b to 94d46c3 Feb 22, 2020
@Mailaender Mailaender force-pushed the Mailaender:less-strict-frame-sequences branch from 94d46c3 to f8bc24d Feb 22, 2020
@pchote
pchote approved these changes Feb 23, 2020
@pchote pchote added the PR: Needs +2 label Feb 23, 2020
@reaperrr reaperrr merged commit 2016ab1 into OpenRA:bleed Feb 23, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender Mailaender deleted the Mailaender:less-strict-frame-sequences branch Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.