Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlayLaunchSounds() to SupportPowers which are missing it #17636

Merged
merged 1 commit into from Feb 9, 2020

Conversation

@MustaphaTR
Copy link
Member

MustaphaTR commented Jan 31, 2020

Fixes #17635.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Jan 31, 2020

Are there any powers other than GpsPower that don't trigger it from Activate? Could we just move this to base.Activate instead?

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Jan 31, 2020

Copy link
Member

Mailaender left a comment

Looks sane and I can't spot side effects in-game.

@reaperrr reaperrr merged commit 6ab0ace into OpenRA:bleed Feb 9, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MustaphaTR MustaphaTR deleted the MustaphaTR:fix-sw-notifications branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.