Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect end point rendering in DrawConnectedLine. #17732

Merged
merged 1 commit into from Feb 29, 2020

Conversation

@pchote
Copy link
Member

pchote commented Feb 27, 2020

This PR fixes a long standing issue with rendering connected line segments: i < limit was true for all points in the loop, so we drew the end point of the last segment as if it were going to be connected back to the first point in the line.

This fixes a glitch with the selection box rendering that has become much more noticable with our expanded HiDPI and UI scaling support:

Before:

After:

The scope for testing and regression here should be minor as the only code that calls DrawConnectedLine with closed: false is DrawLine with connectSegments: true - this is only used by the selection boxes, perf/spectator graphs, and railgun helix effect.

@pchote pchote added this to the Next Release milestone Feb 27, 2020
@Mailaender Mailaender merged commit 93d006e into OpenRA:bleed Feb 29, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Copy link
Member

Mailaender commented Feb 29, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.