Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoTarget regression #17754

Merged
merged 2 commits into from Mar 2, 2020
Merged

Conversation

@pchote
Copy link
Member

pchote commented Mar 1, 2020

This PR fixes #17751 by reverting #17619.

The original issue was introduced by #16797 making aircraft call TickIdle, so a much simpler "fix" for #17476 (i.e. restore the previous behaviour) is to simply disable the idle scanning from RA yak and Mig.

@pchote pchote added this to the Next Release milestone Mar 1, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Mar 1, 2020

Ping @netnazgul and @Punsho to confirm that this fixes both the old and new issues.

Copy link
Contributor

Punsho left a comment

It fixes both, however helicopters also do chase if they acquire a target on defend stance and it moves out of range.

It is not critical to address it here and right now but planes do not honour attack everything stance, they do not give chase

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Mar 2, 2020

That is also the behaviour on release, and the safest option here is to not try and change that.

It looks like FlyAttack has always ignored the allowMove flag, but its not yet clear how difficult or risky that will be to fix.

@netnazgul

This comment has been minimized.

Copy link
Contributor

netnazgul commented Mar 2, 2020

Original issue with tanks (and Longbows) is fixed.

Aircrafts do not return to rearm when given an attack order and out of ammo, is this intended or another regression?

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Mar 2, 2020

Aircrafts do not return to rearm when given an attack order and out of ammo, is this intended or another regression?

We clarified on discord that this was referring to attack-move, which is intentional behaviour and already in the current release.

@matjaeck

This comment has been minimized.

Copy link

matjaeck commented Mar 2, 2020

Aircrafts do not return to rearm when given an attack order and out of ammo, is this intended or another regression?

We clarified on discord that this was referring to attack-move, which is intentional behaviour and already in the current release.

Changed in #17573, first comment is related to the discussion in #16668.

@abcdefg30 abcdefg30 merged commit 4a6fefa into OpenRA:bleed Mar 2, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Mar 2, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.