Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the stroke of the muted indicator glyph #17806

Merged
merged 1 commit into from Mar 24, 2020

Conversation

@dragunoff
Copy link
Contributor

dragunoff commented Mar 16, 2020

I think that the stroke of the muted indicator looks better on the outside.

изображение

Also sneaked in a change to TD chrome image - the cross mark was missing (probably got lost during the UI scale rework). I can separate that into it's own commit if needed.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 18, 2020

The TD chrome-3x sheet needs to be exported at 3072 x 1536 and then have the canvas expanded (on the right and bottom edges) to 4096 x 2048 (similar rules but different dimensions for glyphs-3x). Exporting at 4x breaks the mapped regions!

After fixing the export and testing, I agree that the stroke feels much better at 1x scaling.
IMO the stroke feels too thin wrt the text at 2x and 3x scaling, though:

Are we able to bump the stroke width by a fraction of a px so that the 2x and 3x version look better without impacting the 1x version?

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

dragunoff commented Mar 18, 2020

The TD chrome-3x sheet needs to be exported at 3072 x 1536 and then have the canvas expanded (on the right and bottom edges) to 4096 x 2048 (similar rules but different dimensions for glyphs-3x). Exporting at 4x breaks the mapped regions!

I completely overlooked that. Will fix.

Are we able to bump the stroke width by a fraction of a px so that the 2x and 3x version look better without impacting the 1x version?

Yes, I will try. I think it will work.

@dragunoff dragunoff force-pushed the dragunoff:feature/audio-muted-icon-stroke branch from 32409d3 to 322b703 Mar 19, 2020
@dragunoff

This comment has been minimized.

Copy link
Contributor Author

dragunoff commented Mar 19, 2020

Update: fixed the size of the 3x sprites.

I tried playing with the stroke however on my machine it looks alright at 1px on all UI scales:
audio-muted-stroke

I don't have a hi-dpi display, I'm testing by changing the UI scale in the settings. Is there a difference in rendering between different OS?

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 21, 2020

There shouldn't be a difference between OSes, but it looks like you are only testing the 1-1.5x scale range. The stroke differences only become really obvious at 2x and above.

@dragunoff dragunoff force-pushed the dragunoff:feature/audio-muted-icon-stroke branch from 322b703 to 4c473f8 Mar 23, 2020
@dragunoff

This comment has been minimized.

Copy link
Contributor Author

dragunoff commented Mar 23, 2020

There shouldn't be a difference between OSes, but it looks like you are only testing the 1-1.5x scale range. The stroke differences only become really obvious at 2x and above.

Got it. I still hadn't wrapped my head around the UI scaling entirely. I bumped the stroke by 0.5px and tested by changing OPENRA_DISPLAY_SCALE on linux. here's how it looks:
image

I think it's fairly balanced except for the 1.5 and 2.5 scales but I guess there ain't much we can do about that with the sprites.

Branch is updated with the new sprites.

@pchote
pchote approved these changes Mar 23, 2020
@pchote pchote added the PR: Needs +2 label Mar 23, 2020
@abcdefg30 abcdefg30 merged commit b0dfea0 into OpenRA:bleed Mar 24, 2020
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Mar 24, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.