Extracted the Tiberian Dawn mission objective strings

[Mailaender]

and enhance the Fluent Lua interface.

[abcdefg30]

Is there a specific idea behind splitting some mission translations into their own files instead of having everything in cnc/languages/en.ftl? (Having only a single file seems simpler to me.)

[PunkPun]

Is there a specific idea behind splitting some mission translations into their own files instead of having everything in cnc/languages/en.ftl? (Having only a single file seems simpler to me.)

I think we should keep one file for the main campaign missions, it will be easier for translators and for us to maintain. For skirmish gamemodes or perhaps even for openra unique missions we support translations could be in the maps themselves

[PunkPun]

Not to forget that in the future once we get proper campaign UI we will need translations for those as well on the mod (not engine) level

[penev92]

How does scoping for these mission-specific translation files work? Is there any? If yes, that would be the reason to keep them separate. If we combined them we'd likely need mission-specific prefixes on the string keys like

-destroy-gdi-forces = Destroy all GDI forces.
+nod03-destroy-gdi-forces = Destroy all GDI forces.

[PunkPun]

we would more likely just add comments, like it is in mods/cnc/languages/en.ftl

-nod03-destroy-gdi-forces = Destroy all GDI forces.
+#nod03
+destroy-gdi-forces = Destroy all GDI forces.

[penev92]

That will only work until we start getting conflicting objectives from multiple missions.

[PunkPun]

Applying the #20207 concept would help with that. Though in theory multiple missions shouldn't collide, if they have different wording, since variable name is based on the wording, they will have different variable names

[penev92]

That would likely work, but it neither foolproof nor clean. One would need to be scouring existing strings when adding a new one, finding an unused sequence of characters like trying to register an email account.

[PunkPun]

It's the approach we've taken on engine-level translations. Linting could be added to check for duplicates

[Mailaender]

I went with the monolithic file structure similar to what we already have now.

[PunkPun]

Could we do the Code cleanup. in another PR?

[abcdefg30]

Lgtm otherwise.

[PunkPun]

Changelogs