Fix EjectOnDeath checks#20515
Merged
Merged
Conversation
PunkPun
changed the title
phrohdoh
reviewed
Aug 6, 2023
phrohdoh
left a comment
phrohdoh
left a comment
Member
There was a problem hiding this comment.
Inline question regarding ground-level check & aircraft.
I cannot figure out how to create only the inline comment via the GH Mobile app, seems I have to create a "review."
PunkPun
force-pushed
the
fix-eject
branch
2 times, most recently
from
d7628a7 to
44e5771
Compare
PunkPun
force-pushed
the
fix-eject
branch
3 times, most recently
from
ce82d0f to
b2c905d
Compare
abcdefg30
reviewed
Aug 20, 2023
RoosterDragon
approved these changes
Aug 22, 2023
Mailaender
force-pushed
the
fix-eject
branch
from
ec48a6c to
d86d4fc
Compare
Mailaender
approved these changes
Sep 23, 2023
Member
|
Removed test cases ec48a6c. |
Member
Member
|
This was reverted in #21507 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this PR
EjectOnDeathflag is almost unusable. Both because of ejected troops overlapping, troops being killed when they shouldn't or because of the desyncsFixes #16353
Fixes #17863 by removing
CanUnloadand thusCurrentAdjacentCellscheck fromINotifyKilled.Killed