Skip to content

Allow mission use lobby options#20934

Merged
Mailaender merged 1 commit into
OpenRA:bleedfrom
dnqbob:mission-player-setting
Oct 22, 2023
Merged

Allow mission use lobby options#20934
Mailaender merged 1 commit into
OpenRA:bleedfrom
dnqbob:mission-player-setting

Conversation

@dnqbob

@dnqbob dnqbob commented Jun 25, 2023

Copy link
Copy Markdown
Contributor

1
2

Btw, I didn't fix all mods on this new UI here for I don't know if you will accept this implementation, and I am not a good UI designer.

Update: OK then, I will fix other mods.

@dnqbob dnqbob force-pushed the mission-player-setting branch 4 times, most recently from c2980f8 to 159f521 Compare June 26, 2023 06:49
@dnqbob dnqbob force-pushed the mission-player-setting branch from 159f521 to 69269cf Compare July 3, 2023 07:45
@dnqbob

dnqbob commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

Change name of some vars (player options -> mission options)

@Mailaender

Copy link
Copy Markdown
Member

Why would you want this? Missions are usually crafted with specific game options in mind. Changing them could break the game. It also complicates testing to avoid those blockers.

@dnqbob

dnqbob commented Oct 16, 2023

Copy link
Copy Markdown
Contributor Author

Missions are usually crafted with specific game options in mind. Changing them could break the game.

Why allowing player use the legacy RA setting of fog check, build radius and disable redeploy MCV can break the game? You can always lock and hide the option if you don't want it change.

@abcdefg30

Copy link
Copy Markdown
Member

Why would you want this? Missions are usually crafted with specific game options in mind. Changing them could break the game. It also complicates testing to avoid those blockers.

We shouldn't enable this in the default mods, but might want to consider it in the future. In any case I don't see a reason why we shouldn't allow this for modders.

@Mailaender

Copy link
Copy Markdown
Member

Can you squash the first two commits?

@dnqbob dnqbob force-pushed the mission-player-setting branch 3 times, most recently from da35c32 to 3061ad0 Compare October 21, 2023 19:23
@dnqbob

dnqbob commented Oct 21, 2023

Copy link
Copy Markdown
Contributor Author

Rebased and squashed

@dnqbob dnqbob force-pushed the mission-player-setting branch 3 times, most recently from 419f7e0 to 0595216 Compare October 22, 2023 02:21
@dnqbob

dnqbob commented Oct 22, 2023

Copy link
Copy Markdown
Contributor Author

Rebased again

Mailaender
Mailaender previously approved these changes Oct 22, 2023
@Mailaender

Copy link
Copy Markdown
Member

Removed test case 0595216

@Mailaender Mailaender merged commit b1f5367 into OpenRA:bleed Oct 22, 2023
@Mailaender

Copy link
Copy Markdown
Member

Changelog

@dnqbob dnqbob deleted the mission-player-setting branch October 22, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants