Add the Nod mobile stealth generator#21049
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
PunkPun
reviewed
Sep 11, 2023
PunkPun
reviewed
Sep 11, 2023
Mailaender
force-pushed
the
mobile-stealth
branch
2 times, most recently
from
11cb2f5 to
3b11565
Compare
PunkPun
reviewed
Sep 14, 2023
Mailaender
force-pushed
the
mobile-stealth
branch
from
3b11565 to
686fb54
Compare
Member
|
is there a way we could make it centred? |
Member
|
I agree, there seems to be some kind of visual "jump upwards" when deploying. Can we offset the artwork a bit? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
Adjusted the offset |
Mailaender
force-pushed
the
mobile-stealth
branch
from
686fb54 to
1aea72e
Compare
Member
|
New codestyle failed. Also the sprite seems a pixel off and shadow seems very off. Is that how it was in vanilla? Though I suppose we will need to change the way shadows are in TS anyhow, so this is a mute point
|
Member
|
in the wiki I found this, it seems the shadow is rendered differently for the undeployed version. I suppose the shadow might be the primary reason why the generator feels like teleporting
|
PunkPun
approved these changes
Dec 2, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on