Remove the possibility of ReloadDelay becoming 0 with modifiers - #21074
Merged
Conversation
MustaphaTR
approved these changes
Sep 25, 2023
MustaphaTR
left a comment
MustaphaTR
left a comment
Member
There was a problem hiding this comment.
I can confirm that it fixes the freeze issue.
Contributor
|
Doesn't this change the behavior #21073 originally wanted to solve? That is not needing separate armaments for actors with two barrels? |
Member
Author
|
having reload delay of 0 was never supposed to be allowed. I had explicitly added a check to crash the game if the game defined such a value |
Member
It is |
abcdefg30
approved these changes
Oct 17, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21073